ci: check formatting instead of actually formatting files #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @matthiasweiss Thanks so much. Really appreciate the PR. I think it will be ideal to leave this the way it is. This way when users submit code, it will automatically format the code. This way it's fully automated. Let me know if you have a strong reason against this and we'll take it into consideration. Thanks again for the compliment and hope you have a great day. So excited to get these new starter kits out there 👍 |
Contributor
Author
|
@tnylea got it! But shouldn't it then also commit the code? The way it is set up currently, it formats, but does not commit the formatted code, i.e. the code is only formatted in the run, but not the PR. Or am I wrong here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazing job on the new boilerplates! 🥳
In CI/CD, I usually check if the formatting is correct, rather than do the actual formatting.
This way the job fails, if files are not formatted properly.
Currently, the job would be successful, even if there are improperly formatted files.
This PR changes this to check the formatting, rather than formatting it.
What do you think?
EDIT: if this is wanted, I can also add a PR to the Vue starter kit